chore: reconfigure VPN on reinstall #84
Merged
+20
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanndickson
force-pushed
the
ethan/reconfigure-on-reinstall
branch
from
be8e02f to
194f4bb
Compare
ethanndickson
commented
Feb 28, 2025
| @@ -122,7 +122,7 @@ struct LoginForm: View { | |||
| ).disabled(true) | |||
| } | |||
| Section { | |||
| SecureField("Session Token", text: $sessionToken, prompt: Text("●●●●●●●●")) | |||
There was a problem hiding this comment.
Also removed the prompt because it was a lil confusing, and also the dots were way too big with no way to change it.
Coder Desktop/VPN/Manager.swift
Outdated
Comment on lines
33
to
36
| // URLSession's waiting for connectivity sometimes hangs even when | ||
| // the network is up so this is deliberately short (15s) to avoid a | ||
| // poor UX where it appears stuck. | ||
| sessionConfig.timeoutIntervalForResource = 15 |
There was a problem hiding this comment.
This is a super weird bug, the VPN was stuck connecting after waking my laptop. However, when I cut my network connection, I saw a download failed error, which would suggest that's where it was stuck.
ethanndickson
commented
Feb 28, 2025
| @@ -38,7 +38,7 @@ struct LoginForm: View { | |||
| .animation(.easeInOut, value: currentPage) | |||
| .onAppear { | |||
| baseAccessURL = state.baseAccessURL?.absoluteString ?? baseAccessURL | |||
| sessionToken = "" | |||
There was a problem hiding this comment.
We clear the Keychain password on Sign out - so I don't think this does anything, actually.
ethanndickson
force-pushed
the
ethan/reconfigure-on-reinstall
branch
from
194f4bb to
36fa256
Compare
ThomasK33
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement over the change in #76 - reconfigures on launch if the VPN is unconfigured, but an existing session is present in
UserDefaults& Keychain.Additionally: